Use reasonable default quality levels #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts the default compression algorithm selection and quality levels to use more reasonable values instead of maximum quality settings. The changes make the tool more practical for everyday use by balancing compression ratio with encoding speed.
Key changes:
- Modified default algorithms to exclude deflate compression
- Reduced default quality levels for better performance
- Added validation for compression quality parameters
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/precompress.rs | Updates default algorithms and renames methods for clarity |
| src/main.rs | Adds quality validation and updates method calls |
| src/encode.rs | Implements quality validation and adjusts default quality levels |
| README.md | Documents the new default algorithms and quality levels |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ryanfowler
force-pushed
the
default-quality
branch
from
2690b9e to
8d37d2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.